Add content-type and filename params for file upload #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrRTi
force-pushed
the
feature/add-content-type-for-file-upload
branch
from
dbeae1b
to
9761f19
Compare
abrom
requested changes
Oct 9, 2023
| @@ -110,7 +110,7 @@ def create_request(path, options) | |||
| req = Net::HTTP::Post.new(path, headers) | |||
| add_body(req, body) if body | |||
|
|
|||
| form_data = reject_nils(options[:form_data]) | |||
| form_data = options[:form_data] | |||
There was a problem hiding this comment.
this would appear to be a breaking change. Can you explain why you've made it?
There was a problem hiding this comment.
I don't think it will be a breaking change and here is why:
reject_nilsexpect hash, form data in this update will be array.form_datawas added in my prev PR with file upload and wasn't supported previously in any requests.reject_nilsfor json-bodies are still at row 107form_datais added inlib/rocket_chat/messages/room.rb:322by transforming provided hash to an array of arrays.
3.1. If some params passed by user arenilthey will be cleaned out bycompactatlib/rocket_chat/messages/room.rb:350
3.2. If file-related optional params (filename, content-type) arenilthey will be cleared atlib/rocket_chat/messages/room.rb:353
3.3. I don't see any possible way to receive an array withnilelement atlib/rocket_chat/messages/room.rb:354with 3.1. and 3.2.
On the other hand, for future development, part of file_upload_array at lines lib/rocket_chat/messages/room.rb:352-358 could be moved to request helper to cover all form_data requests from any future endpoints. I could do this in separate PR if this is ok
Co-authored-by: Andrew Bromwich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all files are sent with type
application/octet-stream. This update will add ability to pass content_type and filename as args if neededActual:
Expected:
